Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router fix #19

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Router fix #19

merged 2 commits into from
Jan 30, 2020

Conversation

yiiliveext
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️

Fix codestyle and Route handler logical error

@yiiliveext
Copy link
Contributor Author

yiiliveext commented Jan 30, 2020

This is strange. According to PSR-12 (https://www.php-fig.org/psr/psr-12/#8-anonymous-classes)

new class implements MiddlewareInterface {
}

is the right way. But continuous-integration/styleci/pr thinks otherwise.

@roxblnfk
Copy link
Member

This is strange. According to PSR-12 (https://www.php-fig.org/psr/psr-12/#8-anonymous-classes)

new class implements MiddlewareInterface {
}

is the right way. But continuous-integration/styleci/pr thinks otherwise.

psr:
new class implements MiddlewareInterface
styleci:
new class() implements MiddlewareInterface
linter:
new class implements MiddlewareInterface or new class () implements MiddlewareInterface

( ╯°□°)╯┻┻

But PSR could be adjusted soon: php-fig/fig-standards#1206

@samdark samdark added the type:bug Bug label Jan 30, 2020
@samdark samdark added this to the 1.0.0-alpha1 milestone Jan 30, 2020
@samdark
Copy link
Member

samdark commented Jan 30, 2020

Good catch about the error.

@samdark samdark merged commit 45d16a4 into yiisoft:master Jan 30, 2020
@samdark
Copy link
Member

samdark commented Jan 30, 2020

Thanks!

@yiiliveext yiiliveext deleted the router-fix branch January 30, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants