Router alt nested route

[yiiliveext]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Tests pass?	✔️

This is a little bit better implementation of the Route class.

There are a few significant disadvantages of the current implementation.

1. It is the ability of jumping over handlers.
   Example

//Route
Route::get('/test')
                ->to(new ActionCaller(SiteController::class, 'test', $container))
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Sweet');
                    return $response;
                })
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Home');
                    return $response;
                })
                ->name('site/test'),
//Action
public function test(RouterInterface $router, ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $response = $this->responseFactory->createResponse();
        $response->getBody()->write('My');

        return $response;
    }

Everything is ok now. The output for both implementations is

My Sweet Home

What about breaking it? Let's try it!

Route::get('/test')
                ->to(new ActionCaller(SiteController::class, 'test', $container))
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Sweet');
                    return $response;
                })
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $handler->handle($request);
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Home');
                    return $response;
                })
                ->name('site/test'),

The output for the current inplementation is

We were unable to find the page /test. Home

The output for my implementation is

My Sweet Home

Route::get('/test')
                ->to(new ActionCaller(SiteController::class, 'test', $container))
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $handler->handle($request);
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Sweet');
                    return $response;
                })
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Home');
                    return $response;
                })
                ->name('site/test'),

The output for the current inplementation is

We were unable to find the page /test. Sweet Home

The output for my implementation is

My Sweet Home

2. Ability to get an infinite loop.

Route::get('/test')
                ->to(new ActionCaller(SiteController::class, 'test', $container))
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $handler->dispath($request);
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Sweet');
                    return $response;
                })
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Home');
                    return $response;
                })
                ->name('site/test'),

The result for the current inplementation is

Infinite loop, HTTP ERROR 500

My implementation doesn't have the dispatch() method.

Route::get('/test')
                ->to(new ActionCaller(SiteController::class, 'test', $container))
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $handler->process($request, $handle);
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Sweet');
                    return $response;
                })
                ->prepend(function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($container) {
                    $response = $handler->handle($request);
                    $response->getBody()->write(' Home');
                    return $response;
                })
                ->name('site/test'),

The result for the current inplementation is

Infinite loop, HTTP ERROR 500

My implementation doesn't have the process() method.

Basically the only problem is that we don't have the Route object (as handler) in each middleware.
But I've created a fix for that in the router-fastroute package yiiliveext/router-fastroute@9384900. This is even better. We have the ability to get the current Route object from anywhere we can get RouterInterface::class from the container.

[samdark]

Overall 👍 but there are some important points to consider.

[samdark]

Thanks!