Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rector + Improve CI #236

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Update rector + Improve CI #236

merged 2 commits into from
Feb 20, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 20, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Feb 20, 2024

PR Summary

  • Upgraded the GitHub Workflow Configurations
    We've added new configurations for our GitHub workflow, specifically for push triggers and pull_requests actions. This means our code checks and validations will now run more efficiently based on the new rules set.

  • Updated PHP Version
    We've updated our PHP version from 8.1 to 8.3 in the mutation workflow file .github/workflows/mutation.yml. This will help us keep the codebase compatible with the latest PHP version.

  • Secrets Configuration in Workflow
    Added newly created secrets to the rector job within our workflow. This emphasizes on maintaining the privacy of important data while the job execution.

  • Improvements in the Composer.json File
    Added a new psalm80.xml file regarding the API reference in the composer.json file. We've also set our project to use a newer version ^5.22 of vimeo/psalm and removed an unnecessary yiisoft/config dependency. It's part of our efforts to improve dependency management in our project.

  • Added Issue Handlers in Psalm.xml
    Issue handlers for <MixedAssignment> and <RiskyTruthyFalsyComparison> have been added in psalm.xml. These handlers will help us identify potential code quality issues related to mixed assignment and risky truthy/falsy comparison.

  • Fixed Argument in Implode() Function
    We've also updated the test files tests/GroupTest.php and tests/RouteCollectionTest.php by fixing the arguments passed to the implode() function. These changes improve the robustness of our tests and the quality of our codebase overall.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aa5706) 97.61% compared to head (d03412f) 97.61%.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.x     #236   +/-   ##
=========================================
  Coverage     97.61%   97.61%           
  Complexity      140      140           
=========================================
  Files             9        9           
  Lines           419      419           
=========================================
  Hits            409      409           
  Misses           10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 61c1c7f into 3.x Feb 20, 2024
24 checks passed
@vjik vjik deleted the ci branch February 20, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant