Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve psalm #50

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Improve psalm #50

merged 1 commit into from
Mar 16, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 16, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Mar 16, 2024

PR Summary

  • Addition of a New Job in Workflow File
    This PR updates .github/workflows/static.yml to add a new job named psalm74-80. This job uses a distinct configuration file (psalm74-80.xml) and supports PHP versions 7.4 and 8.0. This means that the system can perform its operations on more current versions of PHP.

  • Dependency Version Update in Composer File
    We've updated the version of vimeo/psalm in our composer.json file. This helps to ensure that our system is using the latest, most secure, and optimized version of the dependency.

  • Enabling Options and Adding Issue Handlers in Psalm Configuration
    Updates to the psalm.xml file include enabling the findUnusedBaselineEntry and findUnusedCode options. These enable our application do a better job at identifying possibly unneeded code snippets or entries, improving the efficiency of our codebase. Two new issue handlers, MixedAssignment and RiskyTruthyFalsyComparison have also been added to help catch and handle additional potential problems in code.

  • New Alternative Psalm Configuration File
    A new configuration file, psalm74-80.xml, was introduced in this PR. This alternative file just enables the MixedAssignment issue handler, giving us flexibility in our testing and troubleshooting process.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fcfc45c) to head (537a6fc).

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #50   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        36        36           
===========================================
  Files              7         7           
  Lines            103       103           
===========================================
  Hits             103       103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 2032995 into master Mar 16, 2024
24 of 25 checks passed
@vjik vjik deleted the psalm branch March 16, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant