Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve path parsing #121

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Improve path parsing #121

merged 4 commits into from
Dec 18, 2023

Conversation

viktorprogger
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

Just don't use regexp when it's not necessary.

@viktorprogger viktorprogger added the status:code review The pull request needs review. label Dec 16, 2023
@viktorprogger viktorprogger requested review from vjik and a team December 16, 2023 21:28
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4507541) 99.76% compared to head (e9ab37d) 99.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #121   +/-   ##
=========================================
  Coverage     99.76%   99.76%           
- Complexity      147      149    +2     
=========================================
  Files             7        7           
  Lines           424      428    +4     
=========================================
+ Hits            423      427    +4     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 16, 2023

PR Summary

  • Newly Introduced StringHelper Methods
    A few new functions namely findBetween(), findBetweenFirst(), and findBetweenLast() have been added to the StringHelper. These are additional utilities aimed at enhancing string manipulation capabilities.

  • Updating the parsePath() Method in StringHelper
    The parsePath() method under StringHelper.php has been improved to exclude the use of complex pattern matching, in specifics, it will not use regular expressions if no delimiter is present in the path. This optimization can increase efficiency and speed when parsing paths without delimiters.

src/StringHelper.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
viktorprogger and others added 2 commits December 17, 2023 15:54
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@samdark samdark merged commit 5eb5666 into master Dec 18, 2023
21 checks passed
@samdark samdark deleted the enhance-path-parsing branch December 18, 2023 10:33
@samdark
Copy link
Member

samdark commented Dec 18, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants