Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuntimeException, if table exists. #58

Closed
wants to merge 1 commit into from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented May 3, 2023

PR Summary

  • Added RuntimeException to DbHelper.php
    Enhanced error handling with the addition of a new exception type
  • Modified ensureTables() and dropTables() methods in DbHelper.php
    Improved the functionality of database table management methods
  • Implemented hasTable() function in DbHelper class
    Added a new private function to check for the existence of a database table
  • Added tests for ensureTables and dropTables methods (AbstractDbhelperTest)
    Introduced tests for the updated functionality of database table management methods

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d5f3e87) 99.18% compared to head (143ad05) 99.19%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage     99.18%   99.19%           
- Complexity       44       45    +1     
=========================================
  Files             2        2           
  Lines           244      247    +3     
=========================================
+ Hits            242      245    +3     
  Misses            2        2           
Impacted Files Coverage Δ
src/DbHelper.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw requested a review from a team May 3, 2023 15:17
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant