Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt last discussion. #59

Merged
merged 2 commits into from
May 7, 2023
Merged

Adopt last discussion. #59

merged 2 commits into from
May 7, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented May 6, 2023

PR Summary

  • Update rector/rector to version 0.16
    Updated the dependency for improved performance and compatibility
  • Move migration files and add new SQL scripts
    Cleaned up package by moving migration files and added new SQL scripts to support various databases (MSSQL, MySQL/MariaDB, Oracle, PostgreSQL, SQLite)
  • Remove DbHelper class and add DbSchemaManager
    Replaced old DbHelper class with a new DbSchemaManager class for better database table management
  • Add getMessagesByCategory() to MessageSourceInterface
    Introduced a new method to retrieve messages by category for better organization
  • Update tests and add new tests
    Updated existing tests and added new tests to ensure quality and compatibility with the changes made
  • Rename database tables and clean up
    Changed the names of the tables in the database for better clarity and removed unused imports

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (d5f3e87) 99.18% compared to head (c6c7e2e) 99.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
- Coverage     99.18%   99.11%   -0.07%     
+ Complexity       44       43       -1     
============================================
  Files             2        2              
  Lines           244      226      -18     
============================================
- Hits            242      224      -18     
  Misses            2        2              
Impacted Files Coverage Δ
src/DbSchemaManager.php 100.00% <100.00%> (ø)
src/MessageSource.php 97.80% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw requested a review from a team May 6, 2023 10:22
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label May 6, 2023
@samdark samdark merged commit 83d712f into master May 7, 2023
149 checks passed
@samdark samdark deleted the adopt-last-discussion branch May 7, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants