Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of yiisoft/translator version ^3.0 #66

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

thenotsoft
Copy link
Member

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues -

Copy link

what-the-diff bot commented Jan 30, 2024

PR Summary

  • Updated Version Constraints for Package 'yiisoft/translator'
    The 'composer.json' file has been updated to accommodate either the 2.2 or 3.0 version of the 'yiisoft/translator' package. This offers more flexibility when working with different versions of the same package.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1780f1) 99.63% compared to head (6712d12) 99.63%.
Report is 1 commits behind head on master.

❗ Current head 6712d12 differs from pull request most recent head 3a74190. Consider uploading reports for the commit 3a74190 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage     99.63%   99.63%           
  Complexity       43       43           
=========================================
  Files             2        2           
  Lines           273      273           
=========================================
  Hits            272      272           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thenotsoft thenotsoft requested a review from a team January 30, 2024 21:05
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good. All that remains is to add a line to changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik merged commit 28b98de into master Jan 31, 2024
33 of 43 checks passed
@vjik vjik deleted the add_support_of_version_3 branch January 31, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants