Fix message in UnexpectedRuleException (#439)

yiisoft · Dec 8, 2022 · 5db30c0 · 5db30c0
1 parent 68be67a
commit 5db30c0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/Exception/UnexpectedRuleException.php b/src/Exception/UnexpectedRuleException.php
@@ -44,9 +44,12 @@ public function __construct(
          */
         object $actualObject
     ) {
-        $actualClassName = $actualObject::class;
-        $message = "Expected \"$expectedClassName\", but {$actualClassName} given.";
-
-        parent::__construct($message);
+        parent::__construct(
+            sprintf(
+                'Expected "%s", but "%s" given.',
+                $expectedClassName,
+                $actualObject::class
+            )
+        );
     }
 }
diff --git a/tests/Rule/Base/DifferentRuleInHandlerTestTrait.php b/tests/Rule/Base/DifferentRuleInHandlerTestTrait.php
@@ -19,7 +19,7 @@ public function testDifferentRuleInHandler(): void
 
         $this->expectException(UnexpectedRuleException::class);
         $this->expectExceptionMessage(
-            'Expected "' . $ruleClassName . '", but ' . RuleWithCustomHandler::class . ' given.'
+            'Expected "' . $ruleClassName . '", but "' . RuleWithCustomHandler::class . '" given.'
         );
         $validator->validate([], [$rule]);
     }