Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested arrays in PropagateOptionsHelper::propagate() #480

Closed
wants to merge 1 commit into from

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #479

@arogachev arogachev self-assigned this Dec 20, 2022
@arogachev arogachev added the type:bug Bug label Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 89.54% // Head: 11.33% // Decreases project coverage by -78.21% ⚠️

Coverage data is based on head (941545c) compared to base (54ee3e0).
Patch coverage: 19.44% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #480       +/-   ##
=============================================
- Coverage     89.54%   11.33%   -78.22%     
+ Complexity      710      709        -1     
=============================================
  Files            86       83        -3     
  Lines          2277     2267       -10     
=============================================
- Hits           2039      257     -1782     
- Misses          238     2010     +1772     
Impacted Files Coverage Δ
...c/Exception/InvalidCallbackReturnTypeException.php 0.00% <0.00%> (-69.24%) ⬇️
...on/RuleHandlerInterfaceNotImplementedException.php 0.00% <0.00%> (-92.86%) ⬇️
src/Exception/RuleHandlerNotFoundException.php 0.00% <0.00%> (-90.91%) ⬇️
src/Exception/UnexpectedRuleException.php 0.00% <0.00%> (-100.00%) ⬇️
src/Helper/PropagateOptionsHelper.php 0.00% <0.00%> (ø)
src/Rule/Each.php 0.00% <0.00%> (-83.34%) ⬇️
src/Rule/Nested.php 0.00% <0.00%> (-82.98%) ⬇️
src/RuleHandlerResolver/RuleHandlerContainer.php 0.00% <0.00%> (-100.00%) ⬇️
...RuleHandlerResolver/SimpleRuleHandlerContainer.php 64.28% <70.00%> (-35.72%) ⬇️
src/Rule/CompareTo.php 0.00% <0.00%> (-100.00%) ⬇️
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arogachev
Copy link
Contributor Author

Completed in #564.

@arogachev arogachev closed this Feb 15, 2023
@arogachev arogachev deleted the 479-propagate-options-tree-support branch February 15, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant