Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summary in debug collector #608

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Fix summary in debug collector #608

merged 3 commits into from
Jun 2, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Jun 2, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

@what-the-diff
Copy link

what-the-diff bot commented Jun 2, 2023

PR Summary

  • Added debug collector for yiisoft/yii-debug
    This PR introduces a new debug collector for better debugging support in the yiisoft/yii-debug package.
  • Fixed issues Split debug #597 and Fix summary in debug collector #608
    These issues have been addressed by incorporating the debug collector as mentioned above (@xepozz, @vjik).
  • Removed empty array from getSummary() in ValidatorCollector class
    An unnecessary empty array has been removed from the getSummary() method, improving code cleanliness.

@vjik vjik requested a review from a team June 2, 2023 07:47
@vjik vjik added the status:code review The pull request needs review. label Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e7b1afa) 94.28% compared to head (05be758) 94.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #608   +/-   ##
=========================================
  Coverage     94.28%   94.29%           
- Complexity      745      746    +1     
=========================================
  Files            88       88           
  Lines          2275     2277    +2     
=========================================
+ Hits           2145     2147    +2     
  Misses          130      130           
Impacted Files Coverage Δ
src/Debug/ValidatorCollector.php 92.85% <100.00%> (+0.54%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik merged commit d2d0028 into master Jun 2, 2023
49 of 51 checks passed
@vjik vjik deleted the fix-tests branch June 2, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants