-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with master branch #715
Conversation
arogachev
commented
May 23, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to this file from readme in root
|
||
### Rules | ||
|
||
- [Built-in rules](built-in-rules.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken link. Check other links also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line to changelog
* use Yiisoft\Validator\ValidationContext; | ||
* | ||
* final class MyRuleHandler implements RuleHandlerInterface | ||
* { | ||
* public function validate(mixed $value, object $rule, ValidationContext $context): Result | ||
* public function validate(mixed $value, RuleInterface $rule, ValidationContext $context): Result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this version need object
.
@@ -65,6 +68,9 @@ public function __construct( | |||
private bool $skipOnError = false, | |||
private Closure|null $when = null | |||
) { | |||
if ($min > count($this->attributes)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line to changelog
@@ -35,6 +35,8 @@ public function validate(mixed $value, object $rule, ValidationContext $context) | |||
$rules = $rule->getRules(); | |||
$result = new Result(); | |||
|
|||
$originalEachKey = $context->getParameter(Each::PARAMETER_EACH_KEY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line to changelog
I don't think we need to backport changes from next major version into 1.x. |