Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base path in View and WebView optional #251

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 15, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Mar 15, 2024

PR Summary

  • Introduced a new feature enhancement
    Updated the project change log (CHANGELOG.md) to include the details of a new feature improvement (Enh Make base path in View and WebView optional #251).

  • Updated the 'View' class for easier use
    Adjusted the blueprint (constructor) of the View class in a couple of core files (src/View.php and src/WebView.php) to make the input parameter $basePath optional. This makes it simpler for the users to utilize this function.

  • Improved error handling in getBasePath() method
    The getBasePath() method in src/ViewTrait.php is modified to raise a specific type of error (LogicException) if the $basePath is not set. This change improves system robustness and makes error debugging more efficient.

  • Included new system checks
    Integrated a new test in tests/ViewTest.php to ascertain how the getBasePath() function behaves when $basePath is missing. This will ensure the reliability of the function under such scenarios.

@vjik vjik added the status:code review The pull request needs review. label Mar 15, 2024
@vjik vjik requested a review from a team March 15, 2024 14:30
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (57372ba) to head (92051b7).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #251   +/-   ##
=========================================
  Coverage     99.26%   99.26%           
- Complexity      307      308    +1     
=========================================
  Files            19       19           
  Lines           811      813    +2     
=========================================
+ Hits            805      807    +2     
  Misses            6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit ab54747 into master Mar 16, 2024
25 of 27 checks passed
@vjik vjik deleted the optional-base-path branch March 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants