-
-
Notifications
You must be signed in to change notification settings - Fork 23
remove login and user model #40
Comments
Why? Once you've installed the template it's yours. |
Because it's not a package which can be updated with It makes it look easy, in the way it is now - but login/user-management/password-recovery/auth-tokens are a complex topic. |
Personally I don't think there is too much logic in |
I want to notify that application templating approach is changing in 3.0. Unfortunately there is no good documentation about it. |
@hiqsol That's pretty cool looking, what's the state of https://github.com/yiisoft/yii-app-template, since it's released under the yiisoft namespace? |
I didn't really get your questions :)
But the Yii 3.0 (all the packages) are now under heavy development. |
I don't like the application nesting approach that much to be honest, IMHO those should be modules. How about changing this repo to contain a very minimal And the |
And how do you distinguish
It is already designed to pick any other modules. You require package (module/plugin) with composer and that's it - if it provides configuration it starts to do its job. |
Yes :) that's why I'd call it A module is a defined term in Yii you need to have a class (usually in
I don't think they are modules, since they have no class extending from
I don't really see a difference between
Yeah, I did read the article ;) Maybe it's just a naming thing. My personal preference is also different when it comes to configuration, I really prefer a single file, since I don't find it easier to find things which are spread across multiple files, but that's not an issue here and should be up to the developer to choose which way he likes best. |
@hiqsol Since you've removed the public folder from this repo as mentioned in https://github.com/yiisoft/yii-app-template/issues/1#issuecomment-414941648 - how is this now supposed to work as an app? |
Good. Definitely we need naming agreements.
We have a little bit here about
Agree. Let's stick to "extension" term. Now extensions become pluggable but they are still extensions. Then about module. Normal yii modules have they urls like |
|
Aren't also the general packages Yii dependent? Can we get rid of the prefix |
If this is a final decision, it should be reworked as a module and the repo name should be changed. |
Yes. What's nice it is that you are completely free to work this way. |
No. |
Yes, but there are less "surprises" why and especially where something is configured in a certain way.
But splitting them into several files is just left-pocket, right-pocket (but I had this topic with many developers :)) - I prefer one file, because it's way easier to search for a certain piece of config. I'll add feedback to the config-plugin about some of my findings.
We're doing this by building our apps upon Docker images which contain a full-featured app by-the-way, it's another topic, but could also be interesting for you, since we're trying to solve the same problem, see https://github.com/dmstr/phd5-template for an example. |
Neat! |
based upon discussion in yiisoft/yii-base-web#40 (comment)
based upon discussion in yiisoft/yii-base-web#40 (comment)
config-plugin collects single file that you can inspect. And I plan to add debug config explaining where did every config value come from.
I'll appreciate it very much! |
based upon discussion in yiisoft/yii-base-web#40 (comment)
I think this issue has enough. |
What steps will reproduce the problem?
Use this template and find out in a few months that the login has a serious security issue. I think we had that in
yii2-app-basic
and/or...advanced
.Or forget to remove the current user/login code when installing a custom module.
What's expected?
Easy updating/patching in case of bugs or security issues, i.e. with
composer
.Docs about how to install a user-management module, ie.
yii2-usuario
.What do you get instead?
It's pretty hard to patch anything which comes from the template.
CC: @cebe
The text was updated successfully, but these errors were encountered: