Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhacements. #25

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Enhacements. #25

merged 5 commits into from
Dec 15, 2020

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ❌
  • update BootstrapAsset::class.
  • add BootstrapIconsAsset::class, BootstrapCdnAsset::class.
  • fixed static analysis antotation htmlOptions in Html::addCssClass().
  • add finals all class.

@terabytesoftw terabytesoftw requested review from samdark and a team December 15, 2020 20:19
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Dec 15, 2020
samdark
samdark requested changes Dec 15, 2020
View reviewed changes
src/Assets/BootstrapAsset.php Outdated Show resolved Hide resolved
src/Assets/BootstrapIconsAsset.php Outdated Show resolved Hide resolved
@samdark samdark added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Dec 15, 2020
@terabytesoftw terabytesoftw added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Dec 15, 2020
@samdark samdark merged commit f6de65e into yiisoft:master Dec 15, 2020
@samdark
Copy link
Member

samdark commented Dec 15, 2020

👍

@Mister-42
Copy link
Contributor

add BootstrapIconsAsset::class

Why does this not have its own package?

@terabytesoftw
Copy link
Member Author

add BootstrapIconsAsset::class

Why does this not have its own package?

it's just an asset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terabytesoftw @samdark @Mister-42