Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage 100%. #24

Merged
merged 7 commits into from Dec 9, 2020
Merged

Increase code coverage 100%. #24

merged 7 commits into from Dec 9, 2020

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌

@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Dec 8, 2020
@terabytesoftw terabytesoftw requested a review from a team December 8, 2020 12:23
@terabytesoftw terabytesoftw changed the title Increase code coverage Increase code coverage 100%. Dec 8, 2020
samdark
samdark approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good except two removals.

src/NavBar.php Show resolved Hide resolved
src/Widget.php Show resolved Hide resolved
@terabytesoftw terabytesoftw requested review from samdark and a team December 9, 2020 14:04
@samdark samdark merged commit b7d446f into yiisoft:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terabytesoftw @samdark