generated from yiisoft/package-template
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhacements Breadcrumbs, update docs. #51
Merged
samdark
merged 11 commits into
yiisoft:master
from
terabytesoftw:enhacements-breadcrumbs
Dec 21, 2021
Merged
Enhacements Breadcrumbs, update docs. #51
samdark
merged 11 commits into
yiisoft:master
from
terabytesoftw:enhacements-breadcrumbs
Dec 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
terabytesoftw
commented
Dec 17, 2021
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
- Clean code.
- Adjust Breadcrumbs template with icons. https://bulma.io/documentation/components/breadcrumb/#icons
- Add more tests.
- Update docs.
Apply fixes from StyleCI
Should we adjust demo somehow? |
The demo has Bootstrap5 and the app doesn't use it, but in bootstrap5.1 a lot has changed. |
samdark
requested changes
Dec 17, 2021
samdark
reviewed
Dec 21, 2021
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.