Separate chain calls (#152)

yiisoft · Jun 1, 2022 · 56bbaba · 56bbaba
1 parent 4be703b
commit 56bbaba
Show file tree

Hide file tree

Showing 6 changed files with 65 additions and 21 deletions.
diff --git a/src/Application.php b/src/Application.php
@@ -82,7 +82,9 @@ protected function doRenderThrowable(Throwable $e, OutputInterface $output): voi
 
     public function addOptions(InputOption $options): void
     {
-        $this->getDefinition()->addOption($options);
+        $this
+            ->getDefinition()
+            ->addOption($options);
     }
 
     public function extractNamespace(string $name, int $limit = null): string

diff --git a/tests/ApplicationTest.php b/tests/ApplicationTest.php
@@ -15,7 +15,9 @@ public function testDispatcherEventApplicationStartup(): void
     {
         $event = new ApplicationStartup();
 
-        $result = $this->getInaccessibleProperty($this->application(), 'dispatcher')->dispatch($event);
+        $result = $this
+            ->getInaccessibleProperty($this->application(), 'dispatcher')
+            ->dispatch($event);
 
         $this->assertSame($event, $result);
     }
@@ -24,15 +26,19 @@ public function testDispatcherEventApplicationShutdown(): void
     {
         $event = new ApplicationShutdown(ExitCode::OK);
 
-        $result = $this->getInaccessibleProperty($this->application(), 'dispatcher')->dispatch($event);
+        $result = $this
+            ->getInaccessibleProperty($this->application(), 'dispatcher')
+            ->dispatch($event);
 
         $this->assertSame($event, $result);
         $this->assertEquals(ExitCode::OK, $event->getExitCode());
     }
 
     public function testDoRenderThrowable(): void
     {
-        $command = $this->application()->find('stub');
+        $command = $this
+            ->application()
+            ->find('stub');
 
         $commandCreate = new CommandTester($command);
 
@@ -63,7 +69,9 @@ public function testDoRenderThrowable(): void
 
     public function testDoRenderThrowableWithStyledOutput(): void
     {
-        $command = $this->application()->find('stub');
+        $command = $this
+            ->application()
+            ->find('stub');
 
         $commandCreate = new CommandTester($command);
 
@@ -92,7 +100,9 @@ public function testDoRenderThrowableWithStyledOutput(): void
 
     public function testRenamedCommand(): void
     {
-        $command = $this->application()->find('stub/rename');
+        $command = $this
+            ->application()
+            ->find('stub/rename');
 
         $commandCreate = new CommandTester($command);
 
@@ -122,6 +132,8 @@ public function namespaceProvider(): array
      */
     public function testExtractNamespace(string $name, ?int $limit, string $expected): void
     {
-        $this->assertSame($expected, $this->application()->extractNamespace($name, $limit));
+        $this->assertSame($expected, $this
+            ->application()
+            ->extractNamespace($name, $limit));
     }
 }
diff --git a/tests/CommandLoaderTest.php b/tests/CommandLoaderTest.php
@@ -26,7 +26,9 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->loader = $this->container()->get(CommandLoaderInterface::class);
+        $this->loader = $this
+            ->container()
+            ->get(CommandLoaderInterface::class);
     }
 
     public function testGetNames(): void
@@ -36,10 +38,18 @@ public function testGetNames(): void
 
     public function testGetAlias(): void
     {
-        $this->assertSame([], $this->loader->get('serve')->getAliases());
-        $this->assertSame(['st'], $this->loader->get('st')->getAliases());
-        $this->assertSame(['st'], $this->loader->get('stub')->getAliases());
-        $this->assertSame([], $this->loader->get('stub/rename')->getAliases());
+        $this->assertSame([], $this->loader
+            ->get('serve')
+            ->getAliases());
+        $this->assertSame(['st'], $this->loader
+            ->get('st')
+            ->getAliases());
+        $this->assertSame(['st'], $this->loader
+            ->get('stub')
+            ->getAliases());
+        $this->assertSame([], $this->loader
+            ->get('stub/rename')
+            ->getAliases());
     }
 
     public function testGetThrowExceptionIfCommandDoesNotExist(): void
@@ -71,7 +81,11 @@ public function testConstructThrowExceptionIfItIsNotPossibleToCreateCommandObjec
         $loader = new CommandLoader(
             new SimpleContainer([], static function () {
                 $reflection = new ReflectionClass(ErrorCommand::class);
-                $definition = $reflection->getConstructor()->getParameters()[0]->getType()->getName();
+                $definition = $reflection
+                    ->getConstructor()
+                    ->getParameters()[0]
+                    ->getType()
+                    ->getName();
 
                 if (class_exists($definition)) {
                     return $reflection->newInstanceArgs(new $definition());

diff --git a/tests/ErrorListenerTest.php b/tests/ErrorListenerTest.php
@@ -18,7 +18,9 @@ public function testOnError()
         $logger = new SimpleLogger();
         $errorListener = new ErrorListener($logger);
 
-        $command = $this->application()->find('serve');
+        $command = $this
+            ->application()
+            ->find('serve');
 
         $consoleErrorEvent = new ConsoleErrorEvent(
             new ArrayInput([]),

diff --git a/tests/ServeCommandTest.php b/tests/ServeCommandTest.php
@@ -13,7 +13,9 @@ final class ServeCommandTest extends TestCase
 {
     public function testServeCommandExecuteWithoutArguments(): void
     {
-        $command = $this->application()->find('serve');
+        $command = $this
+            ->application()
+            ->find('serve');
 
         $commandCreate = new CommandTester($command);
 
@@ -36,7 +38,9 @@ public function testServeCommandExecuteWithoutArguments(): void
 
     public function testServeCommandExecuteWithDocRoot(): void
     {
-        $command = $this->application()->find('serve');
+        $command = $this
+            ->application()
+            ->find('serve');
 
         $commandCreate = new CommandTester($command);
 
@@ -69,7 +73,9 @@ public function testServeCommandExecuteWithDocRoot(): void
 
     public function testErrorWhenAddressIsTaken(): void
     {
-        $command = $this->application()->find('serve');
+        $command = $this
+            ->application()
+            ->find('serve');
 
         $commandCreate = new CommandTester($command);
 
@@ -112,7 +118,9 @@ public function testErrorWhenAddressIsTaken(): void
 
     public function testErrorWhenRouterDoesNotExist(): void
     {
-        $command = $this->application()->find('serve');
+        $command = $this
+            ->application()
+            ->find('serve');
 
         $commandCreate = new CommandTester($command);
 
@@ -136,7 +144,9 @@ public function testErrorWhenRouterDoesNotExist(): void
 
     public function testSuccess(): void
     {
-        $command = $this->application()->find('serve');
+        $command = $this
+            ->application()
+            ->find('serve');
 
         $commandCreate = new CommandTester($command);
 
@@ -168,7 +178,9 @@ public function testSuccess(): void
      */
     public function testAutocompletion(array $input, array $suggestions): void
     {
-        $command = $this->application()->find('serve');
+        $command = $this
+            ->application()
+            ->find('serve');
 
         $commandTester = new CommandCompletionTester($command);
 

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -48,7 +48,9 @@ protected function container(): ContainerInterface
 
     protected function application(): Application
     {
-        return $this->container()->get(Application::class);
+        return $this
+            ->container()
+            ->get(Application::class);
     }
 
     /**