Fix #175: Fix serve under Windows

yiisoft · Mar 31, 2023 · 9c0b7fc · 9c0b7fc
1 parent a26e643
commit 9c0b7fc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## 2.0.1 under development
 
-- no changes in this release.
+- Bug #175: Fix `serve` under Windows (samdark)
 
 ## 2.0.0 February 17, 2023
 

diff --git a/src/Command/Serve.php b/src/Command/Serve.php
@@ -135,7 +135,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return ExitCode::OK;
         }
 
-        passthru('PHP_CLI_SERVER_WORKERS=' . $workers . ' "' . PHP_BINARY . '"' . " -S $address -t \"$documentRoot\" $router");
+        $command = '"' . PHP_BINARY . '"' . " -S $address -t \"$documentRoot\" $router";
+
+        if (DIRECTORY_SEPARATOR !== '\\') {
+            $command = 'PHP_CLI_SERVER_WORKERS=' . $workers . ' ' . $command;
+        }
+
+        passthru($command);
 
         return ExitCode::OK;
     }

diff --git a/src/SymfonyEventDispatcher.php b/src/SymfonyEventDispatcher.php
@@ -17,7 +17,9 @@ public function __construct(private PsrEventDispatcherInterface $dispatcher)
      * Dispatches an event to all registered listeners.
      *
      * @psalm-template T as object
+     *
      * @psalm-param T $event
+     *
      * @psalm-return T
      */
     public function dispatch(object $event, string $eventName = null): object