Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing container dependency #44

Closed
viktorprogger opened this issue Jan 16, 2020 · 3 comments · Fixed by #45
Closed

Missing container dependency #44

viktorprogger opened this issue Jan 16, 2020 · 3 comments · Fixed by #45

Comments

@viktorprogger
Copy link
Contributor

bin/yii file is using our own DI container. I guess we shouldn't require it, but we should not use it directly. Any suggestions?

@samdark
Copy link
Member

samdark commented Jan 16, 2020

It is an entry point for the application same as https://github.com/yiisoft/yii-demo/blob/master/public/index.php so having container implementation there is OK.

Or... do you mean something else?

@viktorprogger
Copy link
Contributor Author

Do you mean I should make my own entry point if I don't want to use this particular package?

@samdark
Copy link
Member

samdark commented Jan 16, 2020

What would you propose instead?

We have no yiisoft/di required btw. so out of the box w/o Yii app in place ./vendor/bin/yii just errors... that's not good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants