Reset the count cache when applying a filter (#183)

Co-authored-by: Aleksei Gagarin <roxblnfk@ya.ru>
yiisoft · Jan 24, 2024 · c40d9e5 · c40d9e5
1 parent b23d5ed
commit c40d9e5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Data/Reader/EntityReader.php b/src/Data/Reader/EntityReader.php
@@ -115,6 +115,7 @@ public function withFilter(FilterInterface $filter): static
             $new->filter = $filter;
             $new->itemsCache = new CachedCollection();
             $new->oneItemCache = new CachedCollection();
+            $new->resetCountCache();
         }
         return $new;
     }

diff --git a/tests/Feature/Data/Reader/EntityReaderTest.php b/tests/Feature/Data/Reader/EntityReaderTest.php
@@ -91,6 +91,18 @@ public function testCountWithLimit(): void
         self::assertSame(count(self::FIXTURES_USER), $reader->count());
     }
 
+    /**
+     * @covers ::count
+     */
+    public function testCountWithFilter(): void
+    {
+        $this->fillFixtures();
+
+        $reader = (new EntityReader($this->select('user')))->withFilter(new Equals('id', 2));
+
+        self::assertSame(1, $reader->count());
+    }
+
     /**
      * @covers ::withLimit
      */