Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yiisoft/data processors #150

Closed
roxblnfk opened this issue Jan 14, 2023 · 1 comment · Fixed by #152
Closed

Fix yiisoft/data processors #150

roxblnfk opened this issue Jan 14, 2023 · 1 comment · Fixed by #152
Labels
good first issue Simple enough issue to start with. help wanted type:bug Bug
Milestone

Comments

@roxblnfk
Copy link
Member

All classes like Yiisoft\Yii\Cycle\Data\Reader\Processor\* are broken because there were changes in the yiisoft/data packages. Need to fix it

@rossaddison
Copy link

rossaddison commented Jan 20, 2023

I notice a couple of namespaces under EntityReader.php need to be adjusted ie.

With reference to composer's "yiisoft/data": "^1.0",

use Yiisoft\Data\Reader\Filter\FilterInterface; <--- to Yiisoft\Data\Reader\FilterInterface ie. remove Filter.

use Yiisoft\Data\Reader\Filter\FilterProcessorInterface; <--- does not exist and needs to be included

The file FilterProcessorInterface.php does not exist under "yiisoft/data": "^1.0" Filter folder, and will need to be included from "yiisoft/data": "^3.0@dev". The package will run after this.

@roxblnfk roxblnfk linked a pull request Jan 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple enough issue to start with. help wanted type:bug Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants