Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #80: Improve command fix-dependencies #84

Merged
merged 2 commits into from Jul 1, 2020
Merged

Issue #80: Improve command fix-dependencies #84

merged 2 commits into from Jul 1, 2020

Conversation

rugabarbo
Copy link
Member

  1. Checks packages of all vendors, not just “yiisoft” vendor.
  2. Takes into account packages that should be provided by other packages.
  3. Keeps a version of packages unchanged when moving between sections “require” and “require-dev”.
  4. Sorts dependencies if flag ‘sort-packages’ is set in composer config and dependency list has been changed.

1) Checks packages of all vendors, not just “yiisoft” vendor.
2) Takes into account packages that should be provided by other packages.
3) Keeps a version of packages unchanged when moving between sections “require” and “require-dev”.
4) Sorts dependencies if flag ‘sort-packages’ is set in composer config and dependency list has been changed.
@samdark samdark added the status:code review The pull request needs review. label Jun 29, 2020
@samdark samdark requested a review from a team June 29, 2020 14:39
@rugabarbo
Copy link
Member Author

@samdark Can I merge it without review? I am already doing new feature, refactoring, tests and improvements based on this commit, so the review is delaying me :(

@samdark
Copy link
Member

samdark commented Jul 1, 2020

OK.

@samdark samdark merged commit e6592c5 into yiisoft:master Jul 1, 2020
@rugabarbo rugabarbo deleted the dependencies-fixer-enhancements branch July 1, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants