Listener factory and checker #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorprogger
added
the
status:under development
|
@viktorprogger is it possible to integrate |
|
@samdark, yes, there will be sattelite PRs in the demo and templates. |
This was referenced Feb 25, 2021
viktorprogger
added
status:code review
samdark
requested changes
Feb 25, 2021
|
|
||
| throw new InvalidEventConfigurationFormatException( | ||
| "Event listeners for $eventName must be an array, $type given." | ||
| "Event listeners for $eventName must be an iterable, $type given." |
There was a problem hiding this comment.
Such check exists in ListenerConfigurationChecker. Should we duplicate it here?
There was a problem hiding this comment.
Yes, 4 lines after this one we do foreach ($listeners.... We just throw an exception instead of php error.
viktorprogger
commented
Feb 26, 2021
viktorprogger
commented
Feb 26, 2021
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
samdark
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is evolution of yiisoft/event-dispatcher#55
Support of invokale objects is added.
Corresponding PRs in the other packages should be merged after this one: