Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD generator #111

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

CRUD generator #111

wants to merge 24 commits into from

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Aug 31, 2023

No description provided.

@xepozz xepozz changed the base branch from master to ar August 31, 2023 12:06
@what-the-diff
Copy link

what-the-diff bot commented Aug 31, 2023

PR Summary

  • Dependency Addition
    The team incorporated new dependencies such as httpsoft/http-basis, yiisoft/active-record, yiisoft/cache, and yiisoft/db-sqlite to boost our project's performance and functionality.

  • Renaming of Classes
    To make the code more intuitive and clear, multiple classes were renamed. For instance, ControllerCommand has been renamed to Command, and ControllerGenerator is now Generator.

  • File Additions
    New source files corresponding to the ActiveRecord and CRUD modules were added. This suggests the addition of new features or functionality related to database operations and basic Create-Read-Update-Delete operations.

  • File and Method Modifications
    The team made changes to several existing methods and file configurations like configure method, getGenerator method, and createGeneratorCommand method to fine-tune the existing operations.

  • Testing
    New test classes such as CodeFileTest, ActiveRecordGeneratorTest, and GiiTest are added, indicating increased testing robustness. This is a good sign as it enhances the overall quality of the solution and ensures it works as intended before being deployed.

  • Error Handling Updates
    The getGenerator method in Validator/TemplateRuleHandler.php now throws a RuntimeException for unknown generators, showing improvements in error handling and potentially improvement in application stability.

  • New Classes for Table Validation
    Introduction of TableExistsHandler and TableExistsRule classes would help validate the existance of specific database tables within the application, potentially enhancing data integrity within our solution.

  • More Secure Code
    A readonly modifier was added to templates property in our application. This means the template data won't be accidentally modified as it can be very important for rendering parts of our applications, which can lead to a more secure, stable product.

  • Template Files
    Changes in template files suggest enhancements in the user interface of the application, potentially leading to improved user experience.

  • Database Support
    The addition of a test.db file indicates that some form of database support has been added, possibly related to testing our application with the database.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Attention: Patch coverage is 0% with 212 lines in your changes missing coverage. Please review.

Project coverage is 31.88%. Comparing base (9ba020a) to head (c02a72b).
Report is 5 commits behind head on master.

Current head c02a72b differs from pull request most recent head a56ee0e

Please upload reports for the commit a56ee0e to get more accurate results.

Files Patch % Lines
src/Generator/CRUD/Generator.php 0.00% 62 Missing ⚠️
src/Generator/CRUD/Command.php 0.00% 53 Missing ⚠️
src/Generator/CRUD/default/index.php 0.00% 35 Missing ⚠️
src/Generator/CRUD/default/view.php 0.00% 32 Missing ⚠️
src/Generator/CRUD/default/controller.php 0.00% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
- Coverage     39.63%   31.88%   -7.75%     
- Complexity      226      251      +25     
============================================
  Files            33       38       +5     
  Lines           873     1085     +212     
============================================
  Hits            346      346              
- Misses          527      739     +212     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from ar to master September 3, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants