Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue #1087 #1093

Closed
wants to merge 2 commits into from
Closed

Fixing issue #1087 #1093

wants to merge 2 commits into from

Conversation

suralc
Copy link
Contributor

@suralc suralc commented Aug 1, 2012

Doing this pr in favor of #1091 and #1092 to fix #1087

Discussion welcome.

This was referenced Aug 1, 2012
@suralc
Copy link
Contributor Author

suralc commented Aug 1, 2012

Related travis builds:
http://travis-ci.org/#!/suralc/yii/builds/2011690 (Fail on 5.3 in CTimeStampBehavior, nothing related to this I guess).

I'll experiment with some tests on Cookies, after this issue is solved (anyone a experience about headers in phpunit and @runInSeperateProcess-annotatuib ;))

@mdomba
Copy link
Member

mdomba commented Aug 2, 2012

Closing this PR as #1091 got merged

@mdomba mdomba closed this Aug 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declaration of CCookieCollection::add() should be compatible with that of CMap::add()
2 participants