New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memcache install for php 5.5 builds in travis #2124

Merged
merged 3 commits into from Feb 19, 2013

Conversation

Projects
None yet
2 participants
@arvenil
Contributor

arvenil commented Feb 18, 2013

Hi

As you can see here:
https://travis-ci.org/yiisoft/yii/jobs/4871285/#L179
Some test are skipped for php 5.5. Those are the one dependent on memcache.

In php 5.4. builds this is just ok:
https://travis-ci.org/yiisoft/yii/jobs/4871284/#L41

There was just small bug in installation of memcache:
arvenil@3c33951#L0R9
(26786cc#L0R9)

I have also switched this script back to #!/bin/sh by removing one bashizm:
arvenil@367c6dc#L0R3
(aea1241#L0L1)

And also silenced output for installing memcache in php 5.5 builds as this was done for previous versions:
arvenil@9a216ae#L0R17
(#931, #927)

In short: Tests in php 5.5 builds which use memcache should work now :)

mdomba added a commit that referenced this pull request Feb 19, 2013

Merge pull request #2124 from arvenil/fix-memcache-install-for-php-5.5
Fix memcache install for php 5.5 builds in travis

@mdomba mdomba merged commit 94a5ee9 into yiisoft:master Feb 19, 2013

@mdomba

This comment has been minimized.

Show comment
Hide comment
@mdomba

mdomba Feb 19, 2013

Member

Merged.. thanks for working on this...

Member

mdomba commented Feb 19, 2013

Merged.. thanks for working on this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment