Fix memcache install for php 5.5 builds in travis #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdomba
added a commit
that referenced
this pull request
Feb 19, 2013
Fix memcache install for php 5.5 builds in travis
|
Merged.. thanks for working on this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
As you can see here:
https://travis-ci.org/yiisoft/yii/jobs/4871285/#L179
Some test are skipped for php 5.5. Those are the one dependent on memcache.
In php 5.4. builds this is just ok:
https://travis-ci.org/yiisoft/yii/jobs/4871284/#L41
There was just small bug in installation of memcache:
https://github.com/arvenil/yii/commit/3c339515d5ccb565c9389e4802ffbe4716902d35#L0R9
(26786cc#L0R9)
I have also switched this script back to
#!/bin/shby removing one bashizm:https://github.com/arvenil/yii/commit/367c6dce7a4367f6d13cc35095c31cf277334c9e#L0R3
(aea1241#L0L1)
And also silenced output for installing memcache in php 5.5 builds as this was done for previous versions:
https://github.com/arvenil/yii/commit/9a216ae3bb3a29ebd28ce8299897c72e74a75473#L0R17
(#931, #927)
In short: Tests in php 5.5 builds which use memcache should work now :)