Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default link in docs/guide shows 404 #197

Closed
cgsmith opened this issue Jul 9, 2020 · 5 comments
Closed

default link in docs/guide shows 404 #197

cgsmith opened this issue Jul 9, 2020 · 5 comments
Assignees
Milestone

Comments

@cgsmith
Copy link

cgsmith commented Jul 9, 2020

What steps will reproduce the problem?

  1. Navigate here: https://www.yiiframework.com/doc/guide/2.0/en/input-validation#data-filtering
  2. Click on default link.
  3. Receive 404

What is the expected result?

Navigate to default core validator page

What do you get instead?

404

Additional info

This happens on @cebe mirror as well http://stuff.cebe.cc/yii2docs/guide-input-validation.html

Any guide on how the docs are generated? All links look correct just isn't rendering the link correctly.

Q A
Yii version master and 2.0.12.1
PHP version n/a
Operating system n/a
@SOHELAHMED7
Copy link

Link that give 404 error : https://www.yiiframework.com/doc/guide/2.0/en/tutorial-core-validators.md#default
Link that give correct redirection : https://www.yiiframework.com/doc/guide/2.0/en/tutorial-core-validators#default

seems .md generated in links in not needed to create working links

@SOHELAHMED7
Copy link

Also I checked other links, they are generated properly. For e,g. link for trim, it does not contain .md in the link

@cgsmith
Copy link
Author

cgsmith commented Jul 11, 2020

@SOHELAHMED7 I thought the same thing about dropping the .md but other places in the docs have it. There is something else causing this that I'm not aware of yet.

@samdark
Copy link
Member

samdark commented Jul 12, 2020

The docs are built with https://github.com/yiisoft/yii2-apidoc. Likely the issue is about it. I'll move it there.

@arogachev
Copy link
Contributor

arogachev commented Nov 24, 2021

@SOHELAHMED7 I thought the same thing about dropping the .md but other places in the docs have it. There is something else causing this that I'm not aware of yet.

.md part is automatically removed for each link during guide generation. The bug occurs when a block contains multiple links, only the first one is processed correctly.

Fixed in 5b2f0b7 (+ 7ceaa5a), also I changed implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants