Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is phpunit/phpunit a root requirement? #308

Closed
particleflux opened this issue Oct 6, 2023 · 0 comments · Fixed by #310
Closed

Why is phpunit/phpunit a root requirement? #308

particleflux opened this issue Oct 6, 2023 · 0 comments · Fixed by #310

Comments

@particleflux
Copy link
Contributor

Shouldn't phpunit be pulled in implicitly by codeception instead of being explicitly required?

As far as I can see it just got added with a more or less "random" PR which synced dependencies with the advanced template.

Introducing commit / PR:
@particleflux particleflux mentioned this issue Oct 6, 2023
Open
particleflux added a commit to particleflux/yii2-app-basic that referenced this issue Oct 13, 2023
@particleflux
Remove explicit phpunit/phpunit requirement
645ec66 
phpunit is not explicitly required, all the included tests run with
codeception, not phpunit (not directly, at least).

Fixes yiisoft#308
@particleflux particleflux mentioned this issue Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove explicit phpunit/phpunit requirement particleflux/yii2-app-basic
1 participant
@particleflux