Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not remove the dependency of curl extension? #27

Closed
hightman opened this issue Jun 7, 2015 · 9 comments
Closed

Why not remove the dependency of curl extension? #27

hightman opened this issue Jun 7, 2015 · 9 comments
Labels
type:enhancement Enhancement
Milestone

Comments

@hightman
Copy link

hightman commented Jun 7, 2015

The PHP built-in function file_get_contents(), fully supports all kinds of HTTP requests since 5.0.0.

I strongly hope to cancel the dependence of CURL, I never like to install extra extension, unless there is no choice.

thanks.

@klimov-paul
Copy link
Member

file_get_contents() can only read the response from URL, it can not perform POST request and does not allow setup of custome headers and so on. CURL extension is necessary.

@samdark
Copy link
Member

samdark commented Jun 7, 2015

@samdark samdark reopened this Jun 7, 2015
@hightman
Copy link
Author

hightman commented Jun 7, 2015

@klimov-paul You really did not knows about the function file_get_contents(), look the third parameter, it almost supports all of HTTP request.

@hightman
Copy link
Author

hightman commented Jun 7, 2015

If you have not plan to implement this feature, I intend to submit the patch, but has not yet begun to write code.

@samdark
Copy link
Member

samdark commented Jun 7, 2015

A patch would be great.

@samdark samdark added the type:enhancement Enhancement label Jun 7, 2015
@klimov-paul
Copy link
Member

Any enhancement at this matter does not make sense unless there is a final resolution on yiisoft/yii2#2953

Migration from CURL to stream will break a BC as some client functions manipulate CURL options.

@samdark
Copy link
Member

samdark commented Jun 7, 2015

Well, if CURL stuff is exposed via public API we definitely can't touch it in 2.0.x.

@hightman
Copy link
Author

hightman commented Jun 8, 2015

Now I open a pull request about #27, But sorry to generate another issue #28. I think this patch will not break the compatible with cURL.

@klimov-paul
Copy link
Member

Resolved via #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants