增加腾讯QQ/微信/微博客户端

[ghost]

Q	A
New feature?	yes
Tests pass?	yes

[samdark]

Thanks for the effort but we aren't going to include more providers into the extension. I suggest releasing it as a separate package. After it's done I can add a link to that package to docs. Thanks!

[ghost]

这几个接口，中国用户使用率100%，由于GFW的问题，多个包安装是非常慢的。

[samdark]

OK. We can make an exception then...

[ghost]

thx

[samdark]

Would be great if you'll add changelog. I'll merge right after.

[ghost]

ok

[ghost]

Add change log to complete.

[samdark]

Merged with some adjustments. Thanks!

[yujiandong]

Hello, I am the author of qq/weibo/wechat auth-client.

https://github.com/yujiandong/yii2-authclient

[ghost]

@yujiandong
Do you mean you are the author of these codes instead of OP?

If it's true, maybe some further attention is needed due to copyright violation.

@samdark

[yujiandong]

@raincious @samdark
Yes, you can compare the codes https://github.com/yujiandong/yii2-authclient
I wrote it for my simpleforum 7 months ago.

But @xutongle change the author name in the file.

[xcodebuild]

You are not author 😒

[lambdaq]

@codefalling https://github.com/xutongle/yii2-authclient/commit/61528adec3f0d9ecc8ff1fa0215e75ec79869649

[ghost]

@yujiandong

LOL. You are not the only victim, see the 'Leaps Framework' this guy contributed to:
https://github.com/leaps/leaps/blob/3be68042b7060d2a6e4aef054efae812e57fda95/framework/Kernel.php

Looks just like:
https://github.com/yiisoft/yii2-framework/blob/master/BaseYii.php

Isn't?

Relax, there are a lot of people who take a ~$400/m full time job writing PHP code. Change the author declaration from other people's code while keep its RUNability is hard enough for them to believe they can "own" the code.

That's why they by the way changed the copyright declaration and remove you from your code as well.

Just want for the assignee make things right.

[lambdaq]

This @xutongle guy has this badass commit

https://github.com/xutongle/yii2-authclient/commit/61528adec3f0d9ecc8ff1fa0215e75ec79869649

The commit message in Chinese reads "solving licensing problems".

I mean srsly? WTF?

[cebe]

Thanks for bringing this to our attention, I have removed the commit from master for now. Need some time to keep up with the comments.

[tooooolong]

@cebe 👍