Only target links with auth-link class #99
Conversation
Rather than all anchor tags being included, only those with the default auth-link class will be handled via this logic.
| @@ -28,7 +28,7 @@ jQuery(function($) { | |||
| return this.each(function() { | |||
| var $container = $(this); | |||
|
|
|||
| $container.find('a').on('click', function(e) { | |||
| $container.find('a.auth-link').on('click', function(e) { | |||
There was a problem hiding this comment.
This would not work in case someone creates link with custom CSS class as auth-link added only in case no other class is specified.
https://github.com/yiisoft/yii2-authclient/blob/master/widgets/AuthChoice.php#L185
There was a problem hiding this comment.
But if someone is already messing with the CSS classes, they can just add auth-link manually. This specific change would at least be be a non-breaking change that would still work for all existing widgets while allowing a certain level of control if needed.
There was a problem hiding this comment.
clientLink() method should be adjusted as well.
There was a problem hiding this comment.
What needs to be adjusted in clientLink()? I'm only seeing the one js file that controls what happens on click.
Pull request for #98