-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duration added to log #40
Comments
Duration of what? |
ahh, now I understand why it isnt in there. It can not be called "duration" because that would imply a duration of the specific logcategory in the message. Lets call it something else: Time to Next Log (TTNL) or something else. |
we have Yii::beginProfile() and Yii::endProfile() for that so you can measure timings for some parts of the app. |
I am aware of that, but this is a totally different way of performance optimization. Let me put it this way: |
@dynasource Does #54 somehow solve this? |
@Deele: you've create a JS solution? Why in Js ;)? If it computes the duration, it would solve this topic, but its rather unconventional to 'not' do this by PHP. |
@dynasource Because, that is easier, and it works already. It is not precise, but allows to search faster when you have hundreds of log entries, and you want to find that one that causes 2 second loading time. Total time between logs does not match total time mentioned in header, that gives me hint, that to create trustful solution, would require through knowledge in debug module and Yii internals. |
well, I tried your solution. The JS looks OK, but durations are connected to the wrong lines, it should have an offset of -1. Although its quite useful in the current form, I don't know if its logical from an architectural perspective. I would not expect a JS solution. Secondary, if Gridviews are applied with pagination, this solution wouldnt do. |
Should be PHP-based. |
duration should be added to the logs panel. This is extremely useful and should not be avaiable for performance only.
The text was updated successfully, but these errors were encountered: