Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration added to log #40

Closed
dynasource opened this issue Aug 10, 2015 · 9 comments
Closed

Duration added to log #40

dynasource opened this issue Aug 10, 2015 · 9 comments
Labels
type:enhancement Enhancement
Milestone

Comments

@dynasource
Copy link
Member

duration should be added to the logs panel. This is extremely useful and should not be avaiable for performance only.

@samdark
Copy link
Member

samdark commented Aug 10, 2015

Duration of what?

@dynasource
Copy link
Member Author

ahh, now I understand why it isnt in there. It can not be called "duration" because that would imply a duration of the specific logcategory in the message.

Lets call it something else: Time to Next Log (TTNL) or something else.

@samdark samdark added the type:enhancement Enhancement label Aug 10, 2015
@cebe
Copy link
Member

cebe commented Aug 10, 2015

we have Yii::beginProfile() and Yii::endProfile() for that so you can measure timings for some parts of the app.

@cebe cebe closed this as completed Aug 10, 2015
@dynasource
Copy link
Member Author

I am aware of that, but this is a totally different way of performance optimization. Let me put it this way:
A) active optimization: implement Yii::beginProfile() and Yii::endProfile()
B) passive optimization: compare timeframes in log to see performance issues

@Deele
Copy link
Contributor

Deele commented Oct 6, 2015

@dynasource Does #54 somehow solve this?

@dynasource
Copy link
Member Author

@Deele: you've create a JS solution? Why in Js ;)? If it computes the duration, it would solve this topic, but its rather unconventional to 'not' do this by PHP.

@Deele
Copy link
Contributor

Deele commented Oct 8, 2015

@dynasource Because, that is easier, and it works already. It is not precise, but allows to search faster when you have hundreds of log entries, and you want to find that one that causes 2 second loading time. Total time between logs does not match total time mentioned in header, that gives me hint, that to create trustful solution, would require through knowledge in debug module and Yii internals.

@dynasource
Copy link
Member Author

well, I tried your solution. The JS looks OK, but durations are connected to the wrong lines, it should have an offset of -1.

Although its quite useful in the current form, I don't know if its logical from an architectural perspective. I would not expect a JS solution. Secondary, if Gridviews are applied with pagination, this solution wouldnt do.

@samdark
Copy link
Member

samdark commented Oct 8, 2015

Should be PHP-based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants