Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dont merge] Fix travis build #202

Closed
wants to merge 1 commit into from
Closed

Conversation

machour
Copy link
Member

@machour machour commented Jan 17, 2019

Trying to understand why Travis builds have been failing for so long.

@beowulfenator
Copy link
Collaborator

I believe this has to do with building certain test servers from source. We are testing for a bunch of different platforms (like different versions of ES and PHP) and some of them are configured to be pulled in from github. (It could also be composer-related, I'm not sure). Anyway, after a certain number of installations github asks for a key. At some point I've tried hardcoding my own key in there, and it seemed to have solved the problem, at least temporarily.

@machour
Copy link
Member Author

machour commented Jan 17, 2019

@samdark I see that builds on master have been failing for a long time, and there's a 2.1 branch in this repo with another failure.

Could you bring me up to date with the situation of this repo? We need running tests before attempting to fix #201

@machour
Copy link
Member Author

machour commented Jan 17, 2019

@beowulfenator with the composer.json change I just made, the problem now seems to be an incompatibility between ES & Yii on dev-master: https://travis-ci.org/yiisoft/yii2-elasticsearch/jobs/480761513

@beowulfenator
Copy link
Collaborator

There are multiple versions of PHP, multiple versions of ES and multiple versions of Yii we should test against. Is it really worth testing all of those combinations?

@machour
Copy link
Member Author

machour commented Jan 17, 2019

If Yii is supposed to provide support for them, then the answer should be "Yes it is" I guess :)

@machour
Copy link
Member Author

machour commented Jan 17, 2019

If it helps pin-pointing the problem, I guess we should try to fix tests for one version of PHP & one version of ES first, and then gradually introduce other combinations.

I'm first trying to understand whether efforts should be put it master or 2.1 before digging any further. If you have some experience with ES (I don't) your help would be greatly appreciated!

@samdark
Copy link
Member

samdark commented Jan 17, 2019

Cluster autodetection did not find any active node. Make sure a GET /_nodes reguest on the hosts defined in the config returns the "http_address" field for each node.

Looks like the instance wasn't started or was started with non-default address.

@samdark samdark added the type:test Test label Jan 17, 2019
@machour
Copy link
Member Author

machour commented Jan 17, 2019

Also seems to be related to the ES version, check #177 (comment)

Is branch 2.1 meant for what we now call Yii 3, or is it a branch aiming at targeting more recent ES versions?

If it's the later, are we going to accept PRs for both master and 2.1 on this repo?

@samdark
Copy link
Member

samdark commented Jan 17, 2019

No. 2.1 is for ES versions. See readme.

@samdark
Copy link
Member

samdark commented Jan 17, 2019

I think it worth releasing 2.0.6 and then moving on to 2.1.0 releases. If there will be need to do 2.0.7 we can create 2.0 branch and do releases from there.

@samdark
Copy link
Member

samdark commented Jan 31, 2019

#208

@samdark
Copy link
Member

samdark commented Jan 31, 2019

Checked it a bit more. The problem is that master of this repository is version 2.0 and it's compatible with ES up to 4 only. Still, we're trying to run against travis's elasticsearch here.

What could be done:

  1. Remove travis elastisearch service.
  2. Optionally use zip-s (https://www.elastic.co/guide/en/elasticsearch/reference/2.4/_installation.html) as I've tried in Experiment to fix tests #210. This way it's easier to test against multiple versions that is done, for example, here: https://github.com/toptal/chewy/blob/master/.travis.yml

@machour
Copy link
Member Author

machour commented Jan 31, 2019

What about #206? Is it fixed by #201 or is another regression?

@samdark
Copy link
Member

samdark commented Feb 1, 2019

Same thing.

@samdark
Copy link
Member

samdark commented Feb 1, 2019

#209 fixes both.

@samdark
Copy link
Member

samdark commented Feb 3, 2019

Fix was applied to #210

@samdark samdark closed this Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants