Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use int/bool instead of integer/boolean in doc blocks #238

Closed
klimov-paul opened this issue Jan 27, 2017 · 1 comment
Closed

Use int/bool instead of integer/boolean in doc blocks #238

klimov-paul opened this issue Jan 27, 2017 · 1 comment
Assignees
@samdark
Labels
type:enhancement Enhancement
Milestone
2.0.6

Comments

@klimov-paul
Copy link
Member

klimov-paul commented Jan 27, 2017 •
edited

What steps will reproduce the problem?

Generate ActiveRecord for table containing interger or boolean fields

What's expected?

Generated class PHPDocs displays attribute types in short name (PHP7 style). e.g. @property int $id

What do you get instead?

Generated class PHPDocs displays attribute types in full name e.g. @property integer $id

Additional info

Q A
Yii version *
PHP version *
Operating system *

Back at Yii2 project there was a decision made to switch long names for integer and boolean types to the short ones: int and bool to match type names introduced by PHP 7.

See yiisoft/yii2#12055
@klimov-paul klimov-paul added the type:enhancement Enhancement label Jan 27, 2017
@samdark samdark added this to the 2.0.6 milestone Jan 27, 2017
@samdark samdark self-assigned this Jan 27, 2017
@samdark
Copy link
Member

samdark commented Jan 27, 2017

Yes. Should be adjusted.

@samdark samdark removed their assignment Jan 27, 2017
MaksimKiselev added a commit to MaksimKiselev/yii2-gii that referenced this issue Jan 28, 2017
@MaksimKiselev
yiisoft#238 Change int/bool instead of integer/boolean in doc blocks
3be3d8a
MaksimKiselev added a commit to MaksimKiselev/yii2-gii that referenced this issue Jan 28, 2017
@MaksimKiselev
yiisoft#238 Change int/bool instead of integer/boolean in doc blocks …
1c23709 
…for generated models
@MaksimKiselev MaksimKiselev mentioned this issue Jan 28, 2017
Merged
@samdark samdark self-assigned this Jan 28, 2017
@tarasio tarasio mentioned this issue Jun 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
type:enhancement Enhancement
Projects
None yet
Milestone
2.0.6
Development

No branches or pull requests
2 participants
@samdark @klimov-paul