Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in CRUD update view generator #329

Merged
merged 2 commits into from
Jan 16, 2018
Merged

Fix bug in CRUD update view generator #329

merged 2 commits into from
Jan 16, 2018

Conversation

ricpelo
Copy link
Contributor

@ricpelo ricpelo commented Jan 16, 2018

{nameAttribute} substring no longer shows.

Fixes #328

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #328

`{nameAttribute}` substring no longer shows.

Fixes #328
@ricpelo
Copy link
Contributor Author

ricpelo commented Jan 16, 2018

Now, update.php view shows correctly:

$this->title = 'Update Socios: ' . $model->id;

@samdark
Copy link
Member

samdark commented Jan 16, 2018

Please add a line to changelog.

@samdark samdark added this to the 2.0.7 milestone Jan 16, 2018
@ricpelo
Copy link
Contributor Author

ricpelo commented Jan 16, 2018

Hope all is OK now.

@samdark samdark merged commit 51e58d7 into yiisoft:master Jan 16, 2018
@samdark
Copy link
Member

samdark commented Jan 16, 2018

Merged. Thank you!

@samdark samdark added the type:bug Bug label Jan 16, 2018
@ricpelo
Copy link
Contributor Author

ricpelo commented Jan 16, 2018

Thanks to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRUD generator update.php contains {nameAttribute} in title
2 participants