In reserve method, if the payload is null, throws an error in PHP 8.1 #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the case when it becomes |
|
I checked the work on the config: Processed over 40,000 jobs in different configurations. The problem could not be reproduced. Is there a proxy between redis and the application and what are the timeouts? |
s1lver
approved these changes
Sep 28, 2023
terabytesoftw
approved these changes
Sep 28, 2023
|
Can we get a changelog line here? |
Merged
I made a PR #495 |
|
@bizley hmm... you merged the PR with the changelog entries, but not the PR itself |
Closed
|
Cheers 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the payload in reserve is null (for example, it can be possible when there is concurrency), the next method (explode) throws a deprecated error in PHP 8.1