Bugfix: Cache::getValue()
should return false
in case of missing key
#247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
\yii\caching\Cache::getValue()
the return value should be "false if the value is not in the cache or expired".Currently
null
is returned by thegetValue()
method. When noserializer
is specified thatnull
is casted to a string and the nativeunserialize()
function is used in\yii\caching\Cache::get()
. Theunserialize()
function returnsfalse
on failure, this actually causes theget
method to return the correct value.However, when a
serializer
is specified (e.g. igbinary_unserialize) thenull
value fromgetValue()
is not casted into a string. On PHP 8.1 this causes an error since a string is expected (https://www.php.net/manual/en/function.igbinary-unserialize.php).When the
getValue()
method would have returned the expectedfalse
, theget()
method would have returned it as is without trying to unserialize it, avoiding the error (yiisoft/yii2/blob/master/framework/caching/Cache.php#L135).This PR fixes the
Cache::getValue()
method by returningfalse
when the requested key is not found.