Add symfony/var-dumper as a requirement?

[javiereguiluz]

What steps will reproduce the problem?

In this class: https://github.com/yiisoft/yii2-shell/blob/master/YiiCaster.php you import a Symfony class: use Symfony\Component\VarDumper\Caster\Caster; but you don't require symfony/var-dumper in the composer.json of this project: https://github.com/yiisoft/yii2-shell/blob/master/composer.json

This works by chance and pure luck. Some package is installing the package you need (symfony/var-dumper) so this works without you actually requiring that package.

What's expected?

symfony/var-dumper should be added to the require section of the composer.json file.

What do you get instead?

Additional info

Q	A
Yii vesion	Any
PHP version	Any
Operating system	Any

[schmunk42]

Makes sense.

We also should create a new release, since there was another requirement update for psy/psysh.
The latest stable release requires symfony/console 2.x

[samdark]

@javiereguiluz totally makes sense. Would you like to handle it in a pull request?

[pana1990]

@javiereguiluz @samdark @schmunk42 psy/psysh has already "symfony/var-dumper" dependency in her composer.json : https://github.com/bobthecow/psysh/blob/master/composer.json#L18

is it necessary to include it in our composer?

[schmunk42]

Yes, since it's used here. If they would remove the dep i.e. our code would break.

[javiereguiluz]

@pana1990 a general rule is that if your own code uses some third-party code directly, you should add it to require or require-dev. In this case, Yii2 is explicitly importing a Symfony class in this line: https://github.com/yiisoft/yii2-shell/blob/master/YiiCaster.php

[pana1990]

Of course, thanks for your reply :)

[bertoost]

@schmunk42 Why is a production package using VarDumper? This is a dev package and now it becomes a production package which also brings some other disadvantages because of this. Since I now can not use latest version of it in dev environments.
Therefore I cannot find the real usage of this Symfony component. Is it really necessary?