Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Smarty 2 #17

Closed
antonmarin opened this issue Oct 19, 2016 · 14 comments
Closed

Not compatible with Smarty 2 #17

antonmarin opened this issue Oct 19, 2016 · 14 comments
Assignees
Labels
Milestone

Comments

@antonmarin
Copy link

antonmarin commented Oct 19, 2016

What steps will reproduce the problem?

What's expected?

What do you get instead?

Additional info

No setCompileDir method

Q A
Yii vesion
PHP version
Operating system
@samdark
Copy link
Member

samdark commented Oct 19, 2016

It is. Should work with either 2.6 or 3. If you have a specific problem, please elaborate it.

@samdark samdark closed this as completed Oct 19, 2016
@antonmarin
Copy link
Author

antonmarin commented Oct 19, 2016

ViewRenderer calls setCompileDir() in init(), which doesn't exist in Smarty. Tested with Smarty 2.6.30

@samdark samdark reopened this Oct 19, 2016
@samdark
Copy link
Member

samdark commented Oct 19, 2016

Yes. It seems to be added in 3.1. Before it was $smarty->compile_dir = "foo";.

@samdark samdark added the type:bug Bug label Oct 19, 2016
@samdark samdark added this to the 2.0.6 milestone Oct 19, 2016
@samdark samdark self-assigned this Oct 19, 2016
@samdark samdark closed this as completed in 520702f Feb 2, 2017
@samdark
Copy link
Member

samdark commented Feb 2, 2017

Fixed.

@antonmarin
Copy link
Author

antonmarin commented Feb 3, 2017

Don't think that it is enough. For example: version 2.6.24. Class Smarty doesn't have method setCacheDir(). What about adapter for v2?

@cebe
Copy link
Member

cebe commented Feb 3, 2017

@samdark just tried to fix support for v2 but it seems nearly every function of the ViewRenderer and Extension class depend on something that only works in smarty 3. Not sure there is any sense in supporting 2.x I have committed my changes to #20 if someone wants to give it a try.

@samdark
Copy link
Member

samdark commented Feb 3, 2017

Actually that's a very good question. @antonmarin why do you need v2 supported? Seems v3 is stable and requirements aren't higher than Yii ones...

@antonmarin
Copy link
Author

Legacy support ((

@samdark
Copy link
Member

samdark commented Feb 3, 2017

So you do support it already somehow? Probably you can share some code?

@antonmarin
Copy link
Author

I'm going to create adapter for 2nd version this weekend. Our current solution is ugly

@samdark
Copy link
Member

samdark commented Feb 3, 2017

Please pick up travis changes @cebe proposed so test run against both versions.

@antonmarin
Copy link
Author

Yep, thanks

@antonmarin
Copy link
Author

Well. I need some help )) Any ideas about ->registerClass method?

@samdark
Copy link
Member

samdark commented Mar 17, 2017

Looks like there's no way to implement it.

antichris pushed a commit to antichris/yii2-smarty that referenced this issue Mar 29, 2017
antichris pushed a commit to antichris/yii2-smarty that referenced this issue Mar 29, 2017
antichris pushed a commit to antichris/yii2-smarty that referenced this issue Jun 22, 2020
antichris pushed a commit to antichris/yii2-smarty that referenced this issue Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants