Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make message class inheritable again #59

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Make message class inheritable again #59

merged 1 commit into from
Aug 22, 2023

Conversation

mtangoo
Copy link
Contributor

@mtangoo mtangoo commented Aug 21, 2023

Some key properties of the class Message are private preventing any proper inheritance.
Open them up by making them protected

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #58

Some key properties of the class Message are private preventing any proper inheritance. Open them up by making them protected
@mtangoo mtangoo self-assigned this Aug 21, 2023
@what-the-diff
Copy link

what-the-diff bot commented Aug 21, 2023

PR Summary

  • Increased Access Level for Certain Properties in 'Message' Class
    The properties related to email and character set in the 'Message' class were restricted to be accessed within the class only. This change will allow these properties to be accessible in any class that extends from the 'Message' class itself thereby providing more flexibility in manipulating this information.

@mtangoo mtangoo merged commit fe4b697 into yiisoft:master Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants