Fix #19130: Fix DbSession breaks in some case

yiisoft · Feb 8, 2022 · 71e810c · 71e810c
1 parent 7a2689e
commit 71e810c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md
@@ -14,6 +14,7 @@ Yii Framework 2 Change Log
 - Bug #19204: Support numbers in Inflector::camel2words (longthanhtran)
 - Bug #19004: Container::resolveCallableDependencies() unable to handle union and intersection types (sartor)
 - Bug #19047: Fix deprecated preg_match() passing null parameters #2 in db\mysql\Schema.php (longthanhtran)
+- Bug #19130: Fix DbSession breaks in some case (longthanhtran)
 
 
 2.0.44 December 30, 2021

diff --git a/framework/web/DbSession.php b/framework/web/DbSession.php
@@ -140,7 +140,7 @@ public function regenerateID($deleteOldSession = false)
                ->queryOne();
         });
 
-        if ($row !== false) {
+        if ($row !== false && $this->getIsActive()) {
             if ($deleteOldSession) {
                 $this->db->createCommand()
                     ->update($this->sessionTable, ['id' => $newID], ['id' => $oldID])
@@ -151,11 +151,6 @@ public function regenerateID($deleteOldSession = false)
                     ->insert($this->sessionTable, $row)
                     ->execute();
             }
-        } else {
-            // shouldn't reach here normally
-            $this->db->createCommand()
-                ->insert($this->sessionTable, $this->composeFields($newID, ''))
-                ->execute();
         }
     }