Fix yii\base\Controller::bindInjectedParams() to not throw error when…

… argument of `ReflectionUnionType` type is passed (#18869)
yiisoft · Sep 6, 2021 · ea60fba · ea60fba · andris-sevcenko · Sep 28, 2021
1 parent 932806b
commit ea60fba
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md
@@ -14,6 +14,7 @@ Yii Framework 2 Change Log
 - Enh #18783: Add `XmlResponseFormatter::$objectTagToLowercase` option to lowercase object tags (WinterSilence, samdark)
 - Bug #18845: Fix duplicating `id` in `MigrateController::addDefaultPrimaryKey()` (WinterSilence, samdark)
 - Bug #17119: Fix `yii\caching\Cache::multiSet()` to use `yii\caching\Cache::$defaultDuration` when no duration is passed (OscarBarrett)
+- Bug #18842: Fix `yii\base\Controller::bindInjectedParams()` to not throw error when argument of `ReflectionUnionType` type is passed (bizley)
 
 
 2.0.43 August 09, 2021

diff --git a/framework/base/Controller.php b/framework/base/Controller.php
@@ -563,6 +563,10 @@ public function findLayoutFile($view)
      */
     final protected function bindInjectedParams(\ReflectionType $type, $name, &$args, &$requestedParams)
     {
+        if (!$type instanceof \ReflectionNamedType || $type->isBuiltin()) {
+            return;
+        }
+
         // Since it is not a builtin type it must be DI injection.
         $typeName = $type->getName();
         if (($component = $this->module->get($name, false)) instanceof $typeName) {

diff --git a/framework/console/Controller.php b/framework/console/Controller.php
@@ -226,7 +226,7 @@ public function bindActionParams($action, $params)
                 }
                 $args[] = $actionParams[$key] = $params[$key];
                 unset($params[$key]);
-            } elseif (PHP_VERSION_ID >= 70100 && ($type = $param->getType()) !== null && !$type->isBuiltin()) {
+            } elseif (PHP_VERSION_ID >= 70100 && ($type = $param->getType()) !== null) {
                 try {
                     $this->bindInjectedParams($type, $name, $args, $requestedParams);
                 } catch (\yii\base\Exception $e) {

diff --git a/framework/web/Controller.php b/framework/web/Controller.php
@@ -177,7 +177,7 @@ public function bindActionParams($action, $params)
                 }
                 $args[] = $actionParams[$name] = $params[$name];
                 unset($params[$name]);
-            } elseif (PHP_VERSION_ID >= 70100 && ($type = $param->getType()) !== null && !$type->isBuiltin()) {
+            } elseif (PHP_VERSION_ID >= 70100 && ($type = $param->getType()) !== null) {
                 try {
                     $this->bindInjectedParams($type, $name, $args, $requestedParams);
                 } catch (HttpException $e) {