enableClientValidation not work on submitting if set enableAjaxValidation to true

[phuczeero]

What steps will reproduce the problem?

My model:

class SignupForm extends \yii\base\Model
{
    public $email;
    public $password;

    public function rules()
    {
        return [
            ['email', 'required'],
            ['email', 'email'],
            ['email', 'unique', 'targetClass' => User::className()],

            ['password', 'required'],
        ];
    }

    public function signup()
    {
        if (!$this->validate()) {
            return null;
        }

        $user = new User;
        $user->email = $this->email;
        $user->setPassword($this->password);
        return $user->save();
    }
}

My controller action:

public function actionSignup()
{
    $model = new SignupForm();
    if ($model->load(Yii::$app->request->post())) {
        if (Yii::$app->request->isAjax) {
            Yii::$app->response->format = Response::FORMAT_JSON;
            return ActiveForm::validate($model);
        }

        if ($model->signup()) {
            return $this->goHome();
        }
    }

    return $this->render('signup', [
        'model' => $model,
    ]);
}

My form:

<?php
    $form = ActiveForm::begin([
        'id' => 'form-signup',
        'action' => ['site/signup'],
        'enableAjaxValidation' => true,
]); ?>

    <?= $form->field($model, 'email', ['inputOptions' => ['autofocus' => 'autofocus']])->input('email') ?>

    <?= $form->field($model, 'password')->passwordInput() ?>

    <?= Html::submitButton('Signup') ?>

<?php ActiveForm::end(); ?>

What is the expected result?

Validate all supported client validations before sending ajax validation request

What do you get instead?

Client validation work correctly on input blur, change event, but send ajax request on submitting although all fields are empty.

Additional info

Q	A
Yii version	2.0.12
PHP version	7.1.10
Operating system	Debian

[phuczeero]

Why 2.0.12 force ajax validation on submitting

yii.activeForm.js

if (needAjaxValidation && ($.isEmptyObject(messages) || data.submitting)) {
}

#11228

[samdark]

Is it OK in 2.0.11?

[phuczeero]

@samdark 2.0.11 not OK.

[samdark]

Would be good if you'll find out if there's a version of Yii that is OK.

[schmunk42]

Client validation work correctly on input blur, change event, but send ajax request on submitting although all fields are empty.

@phuczeero Does this behavior only occur if all fields are empty or also if there are wrong values in them?

[phuczeero]

@schmunk42 As I mentioned above, enableClientValidation and enableAjaxValidation are set to true, all fields are required, and all supported client validation still work correctly until I hit the submit button, the form skip client validation and send ajax validation request to server. I think it OK in this commit e5bcbf4

[schmunk42]

I see, I was just asking if there is a difference between all inputs empty and one or more wrong values.

Could you verify this for debugging without those two rules?

     ['email', 'email'],
     ['email', 'unique', 'targetClass' => User::className()],

but just

     ['email', 'required'],

I remember some strange behavior when using validators, which required server-side validation, but I thought it would be project specific.

[phuczeero]

I removed unique validation and the form still skip client validation and force ajax validation.

[phuczeero]

Change yii.activeForm.js file and it works.

From

if (needAjaxValidation && ($.isEmptyObject(messages) || data.submitting)) {
    // ...
}

to

if (needAjaxValidation && $.isEmptyObject(messages)) {
    // ...
}

[hooman-mirghasemi]

I have same Problem .
I do changes @phuczeero write on top comment.
Thank you @phuczeero .

@samdark is it ok? and have not bad effect I upload my project on real host with this change? (until new release 2.0.16 )

[samdark]

No idea. I haven't tested it. If you'll find it's good, let us know.

[hooman-mirghasemi]

I use it and change yii.activeForm.js in vendor. it seems work correctly!
but i only use it in my localhost , so That's beter to yii team member test it and find best way.

[s1lver]

Reproduced, but, I think that is not exactly true.

[machour]

@s1lver could you elaborate?

[s1lver]

@machour perhaps I have doubts either in the way of correcting or in reproducing the error. Now I can not remember exactly

[hooman-mirghasemi]

Why don't resolve this bug it in 2.0.16.1 milestone?

[machour]

@hooman-pro We don't use milestones for such versions.
If you have a fix, please open a PR.