Invalid rbac migration m180523_151638_rbac_updates_indexes_without_prefix

[rvkulikov]

What steps will reproduce the problem?

(tl;dr):
Look at the following lines:

1. This one is good

   yii2/framework/rbac/migrations/m140506_102106_rbac_init.php

   Line 52 in 9431012

   $this->db = $authManager->db;

2. This is good too

   yii2/framework/rbac/migrations/m170907_052038_rbac_add_index_on_auth_assignment_user_id.php

   Line 45 in 9431012

   $this->db = $authManager->db;

3. This is bad

   yii2/framework/rbac/migrations/m180523_151638_rbac_updates_indexes_without_prefix.php

   Lines 39 to 48 in 9431012

   	public function up()
   	{
   	$authManager = $this->getAuthManager();
   	$this->dropIndex('auth_assignment_user_id_idx', $authManager->assignmentTable);
   	$this->createIndex('{{%idx-auth_assignment-user_id}}', $authManager->assignmentTable, 'user_id');
   	$this->dropIndex('idx-auth_item-type', $authManager->itemTable);
   	$this->createIndex('{{%idx-auth_item-type}}', $authManager->itemTable, 'type');
   	}

---

Third migration uses default db component (which may be different from authManager's db component). And if you use 2 db components, and authManager (DbManager) uses non-default db component, then third migration will just fail (it is good fortune that it just drops some indexes).

Please tell if it's not clear how to reproduce the problem and I'll write more details.

[rvkulikov]

The workaround is obvious:

~/app/config/main.php

//...
    'container' => [
        'definitions' => [
            'm180523_151638_rbac_updates_indexes_without_prefix' => [
                'class' => 'm180523_151638_rbac_updates_indexes_without_prefix',
                'db' => 'proper_db_component'
            ],
        ]
    ],
//...

But I think it's not good. It's better to fix migration than to override migration's db component in every app which uses non-default db component.

[samdark]

@rvkulikov do you want to prepare a pull request?

[rvkulikov]

@samdark OK.