Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gii diff markup copy paste friendly #1897

Closed
creocoder opened this issue Jan 11, 2014 · 7 comments
Closed

Make gii diff markup copy paste friendly #1897

creocoder opened this issue Jan 11, 2014 · 7 comments
Labels
ext:gii status:under development Someone is working on a pull request. type:enhancement
Milestone

Comments

@creocoder
Copy link
Contributor

Trouble is:

trouble

When you'll paste this it will be pasted with line numbers. This is because makup with table used.

@samdark
Copy link
Member

samdark commented Jan 11, 2014

+1 for implementing it. Pretty typical use case.

@tomtomsen
Copy link
Contributor

i would like to give it a try and implement it. if it is ok for you guys

@qiangxue
Copy link
Member

Sure. Feel free to work on this. Thanks!

@creocoder
Copy link
Contributor Author

@qiangxue Please reopen this. Not works. Visually with selection all fine. But when paste numbers still here ) Another approach needed. Like numbers in one container and code in other.

@qiangxue qiangxue reopened this Jan 15, 2014
@lucianobaraglia
Copy link
Contributor

Maybe wrap the code in a div via JS?

@creocoder
Copy link
Contributor Author

@lucianobaraglia I think we need consider changing library for diff...

@qiangxue
Copy link
Member

Agree. The current choice may not be the best one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext:gii status:under development Someone is working on a pull request. type:enhancement
Projects
None yet
Development

No branches or pull requests

5 participants