Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchAllRequest application property #194

Closed
cebe opened this issue May 9, 2013 · 7 comments
Closed

catchAllRequest application property #194

cebe opened this issue May 9, 2013 · 7 comments

Comments

@cebe
Copy link
Member

cebe commented May 9, 2013

I miss the catchAllRequest application property.
Is this an accidental omission, or is there a new way to imploement the catchAllRequest functionality?

http://www.yiiframework.com/forum/index.php/topic/43118-catchallrequest/

@qiangxue
Copy link
Member

qiangxue commented May 9, 2013

We dropped many old features purposely to "clean up" the framework. If you want a feature back, could you please describe the reason why you want it back?

@lubosdz
Copy link
Contributor

lubosdz commented May 30, 2013

Since Yii1 does not support SEO friendly action names, in the past I used catchAllRequest to map /mycontroller/my-seo-friendly-action => Mycontroller::mySeoFriendlyAction().

But URL rules should possibly offer sufficient flexibility to cover this feature I guess..

@andersonamuller
Copy link
Contributor

@lubosdz Yii2 has native support to SEO friendly action names. Have you tried?

@lubosdz
Copy link
Contributor

lubosdz commented May 31, 2013

@andersonamuller That's cool, I didn't know that - now I found it in Controller::createAction() - so any action name with dash [-] or underscore [_] will be accepted in an URL's action name. Very nice.
https://github.com/yiisoft/yii2/blob/master/framework/yii/base/Controller.php

One less reason to keep da catchAll*feature:-)

@cebe
Copy link
Member Author

cebe commented May 31, 2013

@lubosdz not really, it will be MyExampleController::actionAnotherExample mapped to url my-example/another-example.

@lubosdz
Copy link
Contributor

lubosdz commented May 31, 2013

@andersonamuller Uff, even better:-) thanx.

@qiangxue
Copy link
Member

qiangxue commented Jun 1, 2013

IMplemented.

@qiangxue qiangxue closed this as completed Jun 1, 2013
tonydspaniard pushed a commit to tonydspaniard/yii2 that referenced this issue Jun 1, 2013
* upstream:
  Fixed build break.
  Fixes issue yiisoft#194: Added Application::catchAll.
  added missing default to getValue in boostrap tabs
  \yii\widgets\Menu improvement
  Fixes issue yiisoft#467: allow view file to be absent as long as the themed version exists.
  better auto scrolling.
  Fixes issue yiisoft#446: automatically scroll to first error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants