Add binary, set and other missing data types to typeMap list in Mysql Schema

[SOHELAHMED7]

As binary is the real data type in Mysql, it would be more perfect to add it to $typeMap list of \yii\db\mysql\Schema::class

My proposal:

        'enum' => self::TYPE_STRING,
        'varbinary' => self::TYPE_BINARY,
+       'binary' => self::TYPE_BINARY,
        'json' => self::TYPE_JSON,

---

List of missing data types

• set
• binary
• bool
• boolean
• dec
• fixed
• double precision
• GEOMETRY
• point
• LINESTRING
• POLYGON
• MULTIPOINT
• MULTILINESTRING
• MULTIPOLYGON
• GEOMETRYCOLLECTION

---

For set

#19705 (comment)

---

Loosely related to #18409

[samdark]

Sounds alright. Would you please do a pull requests so we have a test runs to verify it doesn't break anything covered?

[SOHELAHMED7]

This issue also stands for set data type in Mysql. Though its corresponding PHP side should be array I think. So possibly implementation for 'set' in Yii should be more work than just adding it to $typeMap list

[SOHELAHMED7]

There are also other data type missing. I will put that in main issue description.

[SOHELAHMED7]

What should be corresponding abstract data type for spatial data type such as geometry, point etc?

[bizley]

I think we should not add spatial types.

[samdark]

We should not add too specific types since the whole idea of DB/AR was to have a commong ground between MySQL, PostgreSQL etc.

[SOHELAHMED7]

string is not real DB type in MySQL but it is still present ('string' => self::TYPE_STRING,) in yii\db\mysql\Schema::$typeMap. I am curious to know reason behind it.

[rob006]

List of missing data types

Most of these non-spatial types are only aliases that can be used while creating/altering column, they're not real MySQL types.

[SOHELAHMED7]

The purpose of adding these data type is that I am building a library on the top of Yii 2. In that lib I allow lib user to put a real DB type. And to validate it I use \yii\db\mysql\Schema::$typeMap

[ilyaplot]

@SOHELAHMED7 you may use uppercase. For example: $this->addColumn('table', 'column', 'BINARY(16)');
Yii2 uses case sensitive mapping.