BaseActiveRecord::isAttributeDirty breaking change >= 2.0.46

[everskies]

I've noticed that #19272 modified the way that ActiveRecord array attributes are compared when marking them as dirty.

The newest version sorts the old and new array values recursively before comparing for equality.

This makes perfect sense for associative arrays, however the change didn't take lists into account.

I assume that we should first check if the array is not associative by using BaseArrayHelper::isIndexed or similar, and sort only if it's associative (not indexed). Otherwise the above mentioned PR is a breaking change and should be noted

What steps will reproduce the problem?

Changing the order of array elements for an ActiveRecord property doesn't mark the attribute as dirty.

$someNewRecord->data = [1, 2];
$someNewRecord->save();

$someNewRecord->data = [2, 1];
$someNewRecord->save();

What is the expected result?

The data attribute should should be [2, 1]

What do you get instead?

The data attribute is [1, 2] (Didn't get committed to DB)

Additional info

Q	A
Yii version	2.0.47
PHP version	8.2
Operating system	Unix

[bizley]

Is the array stored as a JSON in the DB? IIRC the order of the elements there is arbitrary and you cannot rely on it anyway.

[everskies]

Is the array stored as a JSON in the DB? IIRC the order of the elements there is arbitrary and you cannot rely on it anyway.

We're using a MySQL back-end for ActiveRecord. From my understanding, the order of items in an JSON array is preserved, but key => value pairs can be arbitrarily sorted and should not be relied on (hence the linked PR is perfect for that)

[kyliemsauter]

I think there's a still a bug with this, isValueDifferent() is sorting the arrays if they aren't associative when it's supposed to be sorting them when they ARE associative.

yii2/framework/db/BaseActiveRecord.php

Line 1766 in 8517184

if (is_array($newValue) && is_array($oldValue) && !ArrayHelper::isAssociative($oldValue)) {