Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename: mail → mailer #4071

Closed
samdark opened this issue Jun 26, 2014 · 3 comments
Closed

Rename: mail → mailer #4071

samdark opened this issue Jun 26, 2014 · 3 comments
Assignees
@samdark
Labels
type:task
Milestone
2.0 RC

Comments

@samdark
Copy link
Member

samdark commented Jun 26, 2014

  • Rename mail component id to mailer since it's the component that sends email, not email itself.
  • Rename EmailTarget::mail to EmailTarget::mailer.
@samdark samdark added this to the 2.0 RC milestone Jun 26, 2014
@samdark samdark self-assigned this Jun 26, 2014
@qiangxue
Copy link
Member

Fine with me.

@klimov-paul
Copy link
Member

Agreed

@cebe
Copy link
Member

cebe commented Jun 26, 2014

👍

samdark added a commit that referenced this issue Jun 26, 2014
@samdark
Missing files for #4071
0ff0f9d
SDKiller added a commit to SDKiller/zyx-phpmailer that referenced this issue Jun 26, 2014
@SDKiller
Add notice of BC-braeking changes in framework
b498dbf 
See yiisoft/yii2#4071

Rename: mail → mailer
@SDKiller SDKiller mentioned this issue Jun 29, 2014
Merged
SDKiller added a commit to SDKiller/zyx-phpmailer that referenced this issue Jun 29, 2014
@SDKiller
Updated docs according to yiisoft/yii2#4071
c24b53c
SDKiller added a commit to SDKiller/zyx-phpmailer that referenced this issue Jun 29, 2014
@SDKiller
Updated docs according to yiisoft/yii2#4071
e02bdfc
SDKiller added a commit to SDKiller/zyx-phpmailer that referenced this issue Jun 29, 2014
@SDKiller
Updated docs according to yiisoft/yii2#4071
9ab633e
qiangxue pushed a commit to yiisoft/yii2-framework that referenced this issue Jun 29, 2014
@SDKiller
Update BaseMessage.php
3792a38 
See yiisoft/yii2@0ff0f9d

yiisoft/yii2#4071
tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014
@samdark
Fixes yiisoft#4071: mail component renamed to mailer, `yii\log\Em…
83d0ad1 
…ailTarget::$mail` renamed to `yii\log\EmailTarget::$mailer`
tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014
@samdark
Missing files for yiisoft#4071
0ab4866
wenbin1989 pushed a commit to wenbin1989/yii2-framework that referenced this issue Nov 17, 2014
@SDKiller
Update BaseMessage.php
7ca2ff0 
See yiisoft/yii2@0ff0f9d

yiisoft/yii2#4071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
type:task
Projects
None yet
Milestone
2.0 RC
Development

No branches or pull requests
4 participants
@samdark @cebe @qiangxue @klimov-paul